Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to go modules #276

Merged
merged 1 commit into from
Jun 3, 2019
Merged

Switch to go modules #276

merged 1 commit into from
Jun 3, 2019

Conversation

mbarrien
Copy link
Contributor

@mbarrien mbarrien commented Jun 3, 2019

Summary

Changes fogg to be built using Go Modules instead of dep.

Test Plan

See if this builds properly in Travis.

@mbarrien mbarrien requested a review from ryanking June 3, 2019 23:28
@mbarrien mbarrien requested a review from a team as a code owner June 3, 2019 23:28
@codecov
Copy link

codecov bot commented Jun 3, 2019

Codecov Report

Merging #276 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #276   +/-   ##
=======================================
  Coverage   80.04%   80.04%           
=======================================
  Files          17       17           
  Lines        1408     1408           
=======================================
  Hits         1127     1127           
  Misses        160      160           
  Partials      121      121

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b1f947...6ca92b4. Read the comment docs.

Copy link
Contributor

@ryanking ryanking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@mbarrien mbarrien merged commit a5c47fe into master Jun 3, 2019
@mbarrien mbarrien deleted the mbarrien/gomod branch June 3, 2019 23:45
palasha pushed a commit to palasha/fogg that referenced this pull request Apr 7, 2020
@vincenthsh vincenthsh mentioned this pull request Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants